Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARPY-2420 Fix crash because of mismatch between line and pythonLine #2224

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

ghislainpiot
Copy link
Contributor

@ghislainpiot ghislainpiot commented Dec 6, 2024

SONARPY-2420

It solved the crash locally for me, I can't test this because we can't really analyze notebooks in tests without some more refactoring

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title gp/fix empty nested block crash SONARPY-2420 gp/fix empty nested block crash Dec 6, 2024
@ghislainpiot ghislainpiot changed the title SONARPY-2420 gp/fix empty nested block crash SONARPY-2420 Fix crash because of mismatch between line and pythonLine Dec 6, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghislainpiot ghislainpiot merged commit 6060554 into master Dec 9, 2024
13 checks passed
@ghislainpiot ghislainpiot deleted the gp/fix-empty-nested-block-crash branch December 9, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants