Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARPY-2419 Update MetricsTest to stop asserting on deprecated metrics #2223

Merged
merged 1 commit into from
Dec 6, 2024
Merged

SONARPY-2419 Update MetricsTest to stop asserting on deprecated metrics #2223

merged 1 commit into from
Dec 6, 2024

Conversation

guillaume-dequenne-sonarsource
Copy link
Contributor

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource commented Dec 6, 2024 •
edited by jira bot
Loading

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Update MetricsTest to stop asserting on deprecated metrics SONARPY-2419 Update MetricsTest to stop asserting on deprecated metrics Dec 6, 2024
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Dec 6, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

ghislainpiot
ghislainpiot approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@ghislainpiot ghislainpiot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I was not able to find the file complexity metrics was fed when trying to fix it on my PR, is it the rule ?

It is not important for the PR, but we seem to be using a pretty big amount of deprecated code in all the sonar APIs

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource merged commit 02afd06 into master Dec 6, 2024
12 of 13 checks passed
@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource deleted the remove-deprecated-metrics branch December 6, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghislainpiot ghislainpiot ghislainpiot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guillaume-dequenne-sonarsource @ghislainpiot