Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARPY-2407 Refactor Token#line and pythonLine to avoid mixing the two #2218

Merged
merged 1 commit into from
Dec 9, 2024
Merged

SONARPY-2407 Refactor Token#line and pythonLine to avoid mixing the two #2218

merged 1 commit into from
Dec 9, 2024

Conversation

ghislainpiot
Copy link
Contributor

@ghislainpiot ghislainpiot commented Dec 5, 2024 •
edited by jira bot
Loading

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Dec 5, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@ghislainpiot ghislainpiot requested a review from joke1196 December 6, 2024 08:37
joke1196
joke1196 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@joke1196 joke1196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was wondering if there was a way to test the quick fixes with the notebooks, but I think our test framework does not allow for that. Maybe for safety, as we should release on Monday, we could, when merged to master, redeploy peach to see if anything broke before going on weekend, WDYT?

@ghislainpiot
Copy link
Contributor Author

LGTM! I was wondering if there was a way to test the quick fixes with the notebooks, but I think our test framework does not allow for that. Maybe for safety, as we should release on Monday, we could, when merged to master, redeploy peach to see if anything broke before going on weekend, WDYT?

I can put it on the dogfood and redeploy peach if needed, it would make me feel better too

@ghislainpiot ghislainpiot merged commit fceee63 into master Dec 9, 2024
13 checks passed
@ghislainpiot ghislainpiot deleted the SONARPY-2407 branch December 9, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joke1196 joke1196 joke1196 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghislainpiot @joke1196