SONARPY-2406 Fix coverage by moving files between packages #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
ghislainpiot
force-pushed
the
gp/fix-coverage
branch
from
618526d to
5a9ed44
Compare
|
joke1196
approved these changes
Dec 3, 2024
| @@ -31,7 +31,7 @@ | |||
| import org.sonar.python.TestPythonVisitorRunner; | |||
|
|
|||
| import static org.assertj.core.api.Assertions.assertThat; | |||
| import static org.sonar.plugins.python.TestUtils.mapToColumnMappingList; | |||
| import static org.sonar.plugins.python.NotebookTestUtils.mapToColumnMappingList; | |||
There was a problem hiding this comment.
Looking at it, should we also move the highlighter to the frontend?
There was a problem hiding this comment.
I don't think we should do it in this ticket. The issue is that the tests require the creation of a PythonInputFile that depends on the Python class in the plugin. And for the file suffixes we need the key from the plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARPY-2406