Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARPY-2405 Update Orchestrator to version 5.1 #2207

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

guillaume-dequenne-sonarsource
Copy link
Contributor

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource commented Dec 3, 2024

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Update Orchestrator to version 5.1 SONARPY-2405 Update Orchestrator to version 5.1 Dec 3, 2024
Copy link
Contributor

@joke1196 joke1196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a small comment otherwise looks good. Thank you for taking care of this.

@@ -37,7 +37,7 @@
class RulingHelper {

private static final String SQ_VERSION_PROPERTY = "sonar.runtimeVersion";
private static final String DEFAULT_SQ_VERSION = "LATEST_RELEASE";
private static final String DEFAULT_SQ_VERSION = "DEV";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now "DEV" is the latest release? Or is it the latest version on master?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you make me notice that I didn't come back to this.
Prior to Orchestrator 5.1, the fix was to use a tag such as DEV[10.8], and if I understand correctly, LATEST_RELEASE didn't exist anymore. (I tried to fix the failing PR analysis test before updating orchestrator).
With 5.1, DEV has now been brought back (latest master), and so was LATEST_RELEASE (latest release). I shortened DEV[10.8] to DEV in the PR, but I think what I really wanted to do is indeed to add LATEST_RELEASE back...
To me it indeed makes more sense to run our tests on a released version.

Copy link

sonarqube-next bot commented Dec 3, 2024

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource merged commit 5c485d1 into master Dec 3, 2024
11 checks passed
@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource deleted the update-orchestrator branch December 3, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants