SONARPY-2382 fix unary propagation problem #2198
Conversation
Seppli11
force-pushed
the
SONARPY-2382
branch
4 times, most recently
from
6d38e69 to
370b97e
Compare
| (~s)(X) # Ok |
There was a problem hiding this comment.
minor I find it not explicit what you want to test here. What matters is not really the fact that s is unknown but that there is a unary ~ operator applied on s right?
I suggest adding a test in nonCallableCalled called def callable_with_unary_operator and checking that not issue are raised when +,-,~... are applied
There was a problem hiding this comment.
Now that I read the all PR I understand why you called the test function like this. Still, I think it will be clearer for someone who hasn't the context to rewrite this test to be more explicit
| private PythonType calculateUnaryExprType(UnaryExpression unaryExpr) { | ||
| String operator = unaryExpr.operator().value(); | ||
| return TypeUtils.map(unaryExpr.expression().typeV2(), type -> mapUnaryExprType(operator, type)); | ||
| } | ||
|
|
||
| private PythonType mapUnaryExprType(String operator, PythonType type) { | ||
| return switch (operator) { | ||
| case "~" -> mapInvertExprType(type); | ||
| // not cannot be overloaded and always returns a boolean | ||
| case "not" -> boolType; | ||
| case "+", "-" -> mapUnaryPlusMinusType(type); | ||
| default -> PythonType.UNKNOWN; | ||
| }; | ||
| } | ||
|
|
||
| private PythonType mapInvertExprType(PythonType type) { | ||
| if(isIntTypeCheck.check(type) == TriBool.TRUE || isBooleanTypeCheck.check(type) == TriBool.TRUE) { | ||
| return intType; | ||
| } | ||
| return PythonType.UNKNOWN; |
There was a problem hiding this comment.
clean implementation, well done 💪
|
|
||
| expr.accept(trivialTypePropagationVisitor); | ||
| assertThat(expr.typeV2()).isEqualTo(PythonType.UNKNOWN); | ||
| } | ||
| } |
There was a problem hiding this comment.
nit add the extra line there
There was a problem hiding this comment.
Personally, I'm impartial whether there is a line there or not. However, I've definitely removed lines between the last function and the closing curly bracket of the class. Is this style documented?
Seppli11
force-pushed
the
SONARPY-2382
branch
from
0f77bbd to
135ee31
Compare
Seppli11
force-pushed
the
SONARPY-2382
branch
from
135ee31 to
7607d5b
Compare
|
SONARPY-2382