SONARPY-2014 SONARPY-2377 Repair rules reading PythonVisitorContext.pythonFile.contents() on Jupyter notebooks #2192
Conversation
ghislainpiot
changed the title
ghislainpiot
force-pushed
the
SONARPY-2014-b
branch
7 times, most recently
from
3f9b32d to
d7eee32
Compare
ghislainpiot
force-pushed
the
SONARPY-2014-b
branch
from
d7eee32 to
a94ef9d
Compare
|
Small reminder to rebase master as there are changes in the notebook parser test |
|
We should maybe create a ticket to refactor |
| String fileId = path != null ? path.toString() : ipynbFile.toString(); | ||
| LocationInFile locationInFile; | ||
| if (begin.isCompresssed()) { | ||
| var next = mapping.get(lineNumber + 1); |
There was a problem hiding this comment.
Here we could do a null check on next, even if it should not happen we could create tests that can throw NPEs.
We could also just create a ticket (if it does not exists yet) and reference it in the code, specifying what we should
do to compute the correct location. This ticket should have a low priority as this should work for the majority of cases.
There was a problem hiding this comment.
What would we do if next is null? I am not sure it is recoverable
|
|
||
| @Test | ||
| void trailing_whitespace() throws IOException { | ||
| var inputFile = createInputFile(baseDir, "notebook_trailing_whitespace.ipynb", InputFile.Status.CHANGED, InputFile.Type.MAIN); |
There was a problem hiding this comment.
Should we move this parser then to the frontend? Not sure if there is a reason why we kept it here
ghislainpiot
force-pushed
the
SONARPY-2014-b
branch
from
a94ef9d to
8348fc7
Compare
…tents() on Jupyter notebooks SONARPY-2014 TrailingWhitespaceCheck
ghislainpiot
force-pushed
the
SONARPY-2014-b
branch
from
8348fc7 to
c5e82ed
Compare
|
SONARPY-2377
SONARPY-2014 TrailingWhitespaceCheck