Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARPY-2388 Add new GitHub action for stale PRs #2191

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

Wohops
Copy link
Contributor

@Wohops Wohops commented Nov 28, 2024

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Add new GitHub action for stale PRs SONARPY-2388 Add new GitHub action for stale PRs Nov 28, 2024
Copy link
Contributor

@Seppli11 Seppli11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this.

While looking at the documentation, I wondered if it would make sense to exclude renovate PRs

stale:
runs-on: ubuntu-latest
permissions:
issues: write
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the action need writing permission for issues?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it didn't, nice catch

@Wohops
Copy link
Contributor Author

Wohops commented Nov 29, 2024

I believe I want to also keep it for Renovate PRs, @Seppli11. If we don't merge immediately, or fast, these PRs are useless.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@Wohops Wohops merged commit f5d2868 into master Nov 29, 2024
11 checks passed
@Wohops Wohops deleted the mg/stale_pr branch November 29, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants