SONARPY-2353 Improve the reproducer of the S5845 FP when comparing enum objects with types #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-serre-sonarsource
force-pushed
the
ts/SONARPY-2353
branch
2 times, most recently
from
0ea4240 to
1203e18
Compare
…um objects with types
thomas-serre-sonarsource
force-pushed
the
ts/SONARPY-2353
branch
from
1203e18 to
96dab75
Compare
Seppli11
approved these changes
Nov 20, 2024
| def test_type_of_enum_and_enum_class(self): | ||
| EnumType = Enum("EnumType", names=["one", "two"]) | ||
| enum_member = EnumType(1) | ||
| # FP SONARPY-2332: EnumType is a proper "type" object as an instance of "Flag", due to it being an Enum |
There was a problem hiding this comment.
the FP comment doesn't seem to be correct.
Suggested change
| # FP SONARPY-2332: EnumType is a proper "type" object as an instance of "Flag", due to it being an Enum | |
| # FP SONARPY-2332: EnumType is a proper "type" object since the Enum constructor with argument creates a new Enum type |
| def test_type_of_derived_enum_and_derived_enum_class(self): | ||
| DerivedEnumType = DerivedEnumWithoutMembers("DerivedEnumType", names=["one", "two"]) | ||
| derived_enum_member = DerivedEnumType(1) | ||
| # FP SONARPY-2332: DerivedEnumType is a proper "type" object as an instance of "DerivedEnumWithoutMembers", due to it being an Enum |
There was a problem hiding this comment.
Similar to above, I find the wording a bit confusing.
Suggested change
| # FP SONARPY-2332: DerivedEnumType is a proper "type" object as an instance of "DerivedEnumWithoutMembers", due to it being an Enum | |
| # FP SONARPY-2332: DerivedEnumType is a proper "type" object because `DerivedEnumWithoutMembers(str, list)` will create a new enum, just like `Enum(str, list)` would |
|
|
||
| DerivedEnumTypeFromDict = DerivedEnumWithoutMembers("DerivedEnumType", OrderedDict([("one", 1), ("two", 2)])) | ||
| derived_enum_member_from_dict = DerivedEnumTypeFromDict(1) | ||
| # FP SONARPY-2332: DerivedEnumTypeFromDict is a proper "type" object as an instance of "DerivedEnumWithoutMembers", due to it being an Enum |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARPY-2353
Part of