SONARPY-2342 Fix NPE when metaclassFQN resolved to null during a PythonType to Descriptor conversion #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onType to Descriptor conversion
|
maksim-grebeniuk-sonarsource
requested a review
from guillaume-dequenne-sonarsource
guillaume-dequenne-sonarsource
approved these changes
Nov 15, 2024
| @@ -132,6 +132,7 @@ private static Descriptor convert(String moduleFqn, String parentFqn, String sym | |||
| var metaclassFQN = type.metaClasses() | |||
| .stream() | |||
| .map(metaClass -> typeFqn(moduleFqn, metaClass)) | |||
| .filter(Objects::nonNull) | |||
There was a problem hiding this comment.
This here is yet again an example of pitfalls when using streams this way.
You missed this edge case during implementation, and I missed it during review. The coverage was 100%, yet we experienced an NPE after merging.
I think we need to make progress and I don't want to refactor just for the sake of it (maybe typeFqn should return Optional?), but I must admit I'm a bit annoyed that we fall into similar traps so often.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARPY-2342