Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARPY-2338 Fix quality gate issues #2156

Conversation

thomas-serre-sonarsource
Copy link
Contributor

@thomas-serre-sonarsource thomas-serre-sonarsource commented Nov 14, 2024

SONARPY-2338

Part of

@thomas-serre-sonarsource thomas-serre-sonarsource changed the title fix quality gate issues Fix quality gate issues Nov 14, 2024
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Fix quality gate issues SONARPY-2338 Fix quality gate issues Nov 14, 2024
@thomas-serre-sonarsource thomas-serre-sonarsource force-pushed the ts/fix-quality-gate-issues-with-nullable branch from 0574bdf to 13e6fab Compare November 14, 2024 13:51
@thomas-serre-sonarsource
Copy link
Contributor Author

This PR follows this one to get the quality gate back to green.

Copy link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource merged commit 3a83e79 into master Nov 14, 2024
10 checks passed
@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource deleted the ts/fix-quality-gate-issues-with-nullable branch November 14, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants