Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARPY-2328 Document FP on S5845 when comparing enum objects with types #2154

Merged
merged 2 commits into from
Nov 15, 2024
Merged

SONARPY-2328 Document FP on S5845 when comparing enum objects with types #2154

merged 2 commits into from
Nov 15, 2024

Conversation

guillaume-dequenne-sonarsource
Copy link
Contributor

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource commented Nov 13, 2024 •
edited by jira bot
Loading

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource marked this pull request as ready for review November 13, 2024 15:59
thomas-serre-sonarsource
thomas-serre-sonarsource approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@thomas-serre-sonarsource thomas-serre-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I only left a nitpick comment.

python-checks/src/test/resources/checks/tests/assertOnDissimilarTypes.py Outdated Show resolved Hide resolved
@guillaume-dequenne-sonarsource @thomas-serre-sonarsource
Fix after review
f10e432 
Co-authored-by: Thomas Serre <[email protected]>
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource merged commit 05d7b5c into master Nov 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-serre-sonarsource thomas-serre-sonarsource thomas-serre-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guillaume-dequenne-sonarsource @thomas-serre-sonarsource