Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARPY-2325 Fix annotated parameter types propagation if its type is UnresolvedImportType #2151

Merged
merged 1 commit into from
Nov 15, 2024
Merged

SONARPY-2325 Fix annotated parameter types propagation if its type is UnresolvedImportType #2151

merged 1 commit into from
Nov 15, 2024

Conversation

maksim-grebeniuk-sonarsource
Copy link
Contributor

@maksim-grebeniuk-sonarsource maksim-grebeniuk-sonarsource commented Nov 12, 2024 •
edited by jira bot
Loading

guillaume-dequenne-sonarsource
guillaume-dequenne-sonarsource reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left small comment about formatting.
As discussed, let's wait until Peach/Differential validation are back up before merging. That way, we'll better see the impact of this change.

python-frontend/src/test/java/org/sonar/python/semantic/v2/ProjectLevelTypeTableTest.java Outdated
var projectLevelSymbolTable = new ProjectLevelSymbolTable();
var libTree = parseWithoutSymbols(
"""
def imported_function(params: list[str]): ...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting nitpick: there are trailing whitespaces on this line.

guillaume-dequenne-sonarsource
guillaume-dequenne-sonarsource approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix the small formatting issue before merging.

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@maksim-grebeniuk-sonarsource maksim-grebeniuk-sonarsource merged commit 4ea4b2e into master Nov 15, 2024
10 checks passed
@maksim-grebeniuk-sonarsource maksim-grebeniuk-sonarsource deleted the SONARPY-2325 branch November 15, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maksim-grebeniuk-sonarsource @guillaume-dequenne-sonarsource