SONARPY-2319 Add unit test case on S5886 when annotated return type is imported and has fields members only #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s imported and has fields members only
maksim-grebeniuk-sonarsource
force-pushed
the
SONARPY-2319
branch
from
04ff855 to
8d3ee90
Compare
|
maksim-grebeniuk-sonarsource
requested a review
from thomas-serre-sonarsource
thomas-serre-sonarsource
approved these changes
Nov 12, 2024
Comment on lines
+38
to
+44
| @Test | ||
| void importedTypesTest() { | ||
| PythonCheckVerifier.verify(List.of( | ||
| "src/test/resources/checks/functionReturnTypeImported.py", | ||
| "src/test/resources/checks/functionReturnTypeImporting.py" | ||
| ), new FunctionReturnTypeCheck()); | ||
| } |
There was a problem hiding this comment.
nit formatting
Suggested change
| @Test | |
| void importedTypesTest() { | |
| PythonCheckVerifier.verify(List.of( | |
| "src/test/resources/checks/functionReturnTypeImported.py", | |
| "src/test/resources/checks/functionReturnTypeImporting.py" | |
| ), new FunctionReturnTypeCheck()); | |
| } | |
| @Test | |
| void importedTypesTest() { | |
| PythonCheckVerifier.verify( | |
| List.of("src/test/resources/checks/functionReturnTypeImported.py", "src/test/resources/checks/functionReturnTypeImporting.py"), | |
| new FunctionReturnTypeCheck() | |
| ); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARPY-2319