SONARPY-2315 Add unit test case on S5890 when annotated type is imported and has field members only #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted and has fields members only
maksim-grebeniuk-sonarsource
requested a review
from thomas-serre-sonarsource
thomas-serre-sonarsource
changed the title
thomas-serre-sonarsource
approved these changes
Nov 8, 2024
| v : int = 10 | ||
|
|
||
| class B: | ||
| def foo(self): ... |
There was a problem hiding this comment.
nit You can add an empty line here.
Comment on lines
1
to
5
| class A: | ||
| v : int = 10 | ||
|
|
||
| class B: | ||
| def foo(self): ... |
There was a problem hiding this comment.
minor To be more explicit about the intention of the test, I suggest to rename the classes
Suggested change
| class A: | |
| v : int = 10 | |
| class B: | |
| def foo(self): ... | |
| class ClassWithFieldOnly: | |
| v : int = 10 | |
| class ClassWithMethodOnly: | |
| def foo(self): ... |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARPY-2315