Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARPY-2255 add tests for S5756 on aliased classes #2129

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

thomas-serre-sonarsource
Copy link
Contributor

@thomas-serre-sonarsource thomas-serre-sonarsource commented Nov 4, 2024


imported_non_callable = MyNonCallableClass()
imported_non_callable_alias = nonCallableCalledImported.MyNonCallableClassAlias()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was throwing an FP on MMF-3945

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I took the liberty to commit the documented FN as well.

Copy link

sonarqube-next bot commented Nov 6, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource merged commit db907a1 into master Nov 6, 2024
9 of 11 checks passed
@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource deleted the ts/SONARPY-2255 branch November 6, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants