Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARPY-2298 document new issues in S5795 stemming from better type resolution #2127

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

Seppli11
Copy link
Contributor

@Seppli11 Seppli11 commented Nov 1, 2024

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title document S5795 FPs stemming from better type resolution SONARPY-2298 document S5795 FPs stemming from better type resolution Nov 1, 2024
Copy link

sonarqube-next bot commented Nov 1, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@@ -160,3 +160,10 @@ def potential_null_symbols():
def comparison_to_class(arg):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note on PR title/ticket name: they're not FPs strictly speaking. They just might be a bit noisy for users.
I think you could say "Document S5795 new issues stemming from better type resolution" to be more neutral.

@Seppli11 Seppli11 changed the title SONARPY-2298 document S5795 FPs stemming from better type resolution SONARPY-2298 document new issues in S5795 stemming from better type resolution Nov 4, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource merged commit c48a2ff into master Nov 4, 2024
14 checks passed
@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource deleted the document-fps-s5795 branch November 4, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants