Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MMF-3945 #2115

Merged
merged 12 commits into from
Nov 6, 2024
Merged

MMF-3945 #2115

merged 12 commits into from
Nov 6, 2024

Conversation

guillaume-dequenne-sonarsource
Copy link
Contributor

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource commented Oct 30, 2024 •
edited by jira bot
Loading

guillaume-dequenne-sonarsource
guillaume-dequenne-sonarsource commented Oct 30, 2024
View reviewed changes
.../sonar/plugins/python/indexer/SonarLintPythonIndexerProjectLevelSymbolTableBuildingTest.java Outdated
@@ -0,0 +1,121 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I have the feeling that, as we don't use keep dedicated V2 and V1 APIs for descriptors, this test is redundant, since existing tests on indexing will cover its use cases.
I'd like your opinion before removing it though @maksim-grebeniuk-sonarsource & @thomas-serre-sonarsource.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I m fine to remove those tests! 👍

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource marked this pull request as ready for review November 6, 2024 15:59
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Nov 6, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
10 Fixed issues
3 Accepted issues

Measures
0 Security Hotspots
97.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

maksim-grebeniuk-sonarsource
maksim-grebeniuk-sonarsource reviewed Nov 6, 2024
View reviewed changes
python-frontend/src/test/java/org/sonar/python/semantic/ProjectLevelSymbolTableTest.java

@Test
@Disabled("SONARPY-2250")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how critical is it, but this disabled test actually doesn't highlight what is wrong with the inheritance from a nested class, and it passes successfully, however, there is another problem - an incorrect superclass symbol fully qualified name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Let's merge this branch and have a look on that against master tomorrow.

maksim-grebeniuk-sonarsource
maksim-grebeniuk-sonarsource approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guillaume-dequenne-sonarsource guillaume-dequenne-sonarsource merged commit 61cd108 into master Nov 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maksim-grebeniuk-sonarsource maksim-grebeniuk-sonarsource maksim-grebeniuk-sonarsource approved these changes

@thomas-serre-sonarsource thomas-serre-sonarsource Awaiting requested review from thomas-serre-sonarsource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guillaume-dequenne-sonarsource @thomas-serre-sonarsource @maksim-grebeniuk-sonarsource