SONARPY-2262 Introduce the TypesTable interface #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksim-grebeniuk-sonarsource
force-pushed
the
SONARPY-2262
branch
from
65d7e58 to
fa7ec6e
Compare
maksim-grebeniuk-sonarsource
force-pushed
the
SONARPY-2262
branch
from
fa7ec6e to
b7966b6
Compare
|
maksim-grebeniuk-sonarsource
requested review from
guillaume-dequenne-sonarsource and
ghislainpiot
ghislainpiot
approved these changes
Oct 28, 2024
Comment on lines
+43
to
+49
| @Override | ||
| public Optional<PythonType> resolveMember(String memberName) { | ||
| var memberFqn = Stream.of(importPath, memberName) | ||
| .filter(Predicate.not(String::isEmpty)) | ||
| .collect(Collectors.joining(".")); | ||
| return Optional.of(new UnresolvedImportType(memberFqn)); | ||
| } |
There was a problem hiding this comment.
I think we might want to extend this idea in the future, by allowing the creation of a "fake" type hierachy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARPY-2262