SONARPY-2219 Pass the result of the type inference for a Python file to ProjectLevelTypesTable #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-serre-sonarsource
force-pushed
the
ts/SONARPY-2111/SONARPY-2219
branch
2 times, most recently
from
715fcaf to
2814c69
Compare
maksim-grebeniuk-sonarsource
force-pushed
the
ts/SONARPY-2111/SONARPY-2219
branch
from
2814c69 to
99f2870
Compare
thomas-serre-sonarsource
force-pushed
the
ts/SONARPY-2111/SONARPY-2219
branch
from
155a04b to
0fb0591
Compare
maksim-grebeniuk-sonarsource
force-pushed
the
ts/SONARPY-2111/SONARPY-2219
branch
3 times, most recently
from
c2ef2f0 to
70a3232
Compare
thomas-serre-sonarsource
force-pushed
the
ts/SONARPY-2111/SONARPY-2219
branch
from
3c4fa83 to
15281f4
Compare
| assertThat(ambiguousDescriptor.name()).isEqualTo("myUnionType"); | ||
| assertThat(ambiguousDescriptor.fullyQualifiedName()).isEqualTo("foo.myUnionType"); | ||
| assertThat(ambiguousDescriptor.kind()).isEqualTo(Descriptor.Kind.AMBIGUOUS); | ||
| // TODO SONARPY-2225 the two class types in the union are rigorously the same but the converter creates an ambigouous descriptor |
There was a problem hiding this comment.
I believe it is to be expected since we don't implement equals for PythonType and expect the unicity of PythonType objects for each available type.
I guess that means that we'd have an ambiguous descriptor in the case where there are 2 definitions that are strictly identical:
if x:
class A: ...
else:
class A: ...
However, I think it's okay to accept this behavior for now. If this prevents proper resolution in some cases, we can always implement something that would merge types that are essentially identical.
maksim-grebeniuk-sonarsource
force-pushed
the
ts/SONARPY-2111/SONARPY-2219
branch
6 times, most recently
from
c1511fb to
2c09e71
Compare
maksim-grebeniuk-sonarsource
force-pushed
the
ts/SONARPY-2111/SONARPY-2219
branch
from
2c09e71 to
7b42049
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.