SONARPY-1530 Fix FN and FP regarding the Ellipsis and the ellipsis ty…

…pe. (#1619)

its/ruling/src/test/resources/expected/python-S5806.json

@@ -658,9 +658,6 @@
 836,
 5816,
 ],
-'project:tensorflow/python/ops/linalg_grad.py':[
-61,
-],
 'project:tensorflow/python/ops/math_ops.py':[
 751,
 786,

python-checks/src/main/java/org/sonar/python/checks/BuiltinShadowingAssignmentCheck.java

@@ -58,6 +58,7 @@ public class BuiltinShadowingAssignmentCheck extends PythonSubscriptionCheck {
   public static final String RENAME_PREFIX = "_";
   public static final String QUICK_FIX_MESSAGE_FORMAT = "Rename to " + RENAME_PREFIX+ " %s";
   private final Map<Symbol, PreciseIssue> variableIssuesRaised = new HashMap<>();
+  public static final String ELLIPSIS = "ellipsis";
 
   @Override
   public void initialize(Context context) {
@@ -184,6 +185,10 @@ private boolean shouldReportIssue(Tree tree) {
   }
 
   private boolean isBuiltInName(Name name) {
+    // Workaround to fix the FP raised. A definite fix should be implemented as part of SONARPY-1531.
+    if (ELLIPSIS.equals(name.name())) {
+      return false;
+    }
     return TypeShed.builtinSymbols().containsKey(name.name());
   }
 }

python-checks/src/test/resources/checks/builtinShadowing.py

@@ -34,3 +34,7 @@ def redefine():
 def iPython():
     display = 42
 
+def ellipsis_test():
+    ellipsis = "" # OK
+    Ellipsis = 42 # Noncompliant {{Rename this variable; it shadows a builtin.}}
+    ellipsis = "..." # OK