Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix controller memory leak #616

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix controller memory leak #616

wants to merge 3 commits into from

Conversation

shaikatz
Copy link
Contributor

@shaikatz shaikatz commented Mar 29, 2021 •
edited
Loading

Since the reconciliation loop was added, the watcher not being disposed correctly leading to a memory leak.
Closes #617

@shaikatz shaikatz requested a review from omerlh March 29, 2021 13:33
omerlh
omerlh previously approved these changes Mar 29, 2021
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerlh omerlh omerlh left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Controller getting OOM
2 participants
@shaikatz @omerlh