Implemented the mentor's backend. #1492
Conversation
…ion-service-with-chatgpt
Services/Mentor/OJS.Services.Mentor.Business/OJS.Services.Mentor.Business.csproj
Show resolved
Hide resolved
|
|
||
| if (userMentor.RequestsMade > (userMentor.QuotaLimit ?? GetNumericValue(settings, nameof(MentorQuotaLimit)))) | ||
| { | ||
| throw new BusinessServiceException($"You have reached your message limit, please try again after {GetTimeUntilNextMessage(userMentor.QuotaResetTime)}."); |
There was a problem hiding this comment.
How is this displayed? I don't like throwing exception for expected (and frequent) behavior. We should handle this case by returning a message in the response model.
There was a problem hiding this comment.
Is it necessary to add another property to the response model just for this case? Aren't exceptions (BusinessServiceExceptions), supposed to handle cases where the user has made a mistake / a user specific error has occurred and it has to be displayed?
There was a problem hiding this comment.
I don't consider this a user mistake. The user is not responsible to track the reset time. BusinessServiceException indicates that some violation of the business logic has happened - and this is not a violation, but normal and totally expected behavior.
Apart from this, I don't like the BusinessServiceException either. Better alternative would be to return a result with the error in the response, than throwing.. but this is another topic.
Services/Mentor/OJS.Services.Mentor.Business/Implementations/MentorBusinessService.cs
Outdated
Show resolved
Hide resolved
Services/Mentor/OJS.Services.Mentor.Business/Implementations/MentorBusinessService.cs
Outdated
Show resolved
Hide resolved
Services/Mentor/OJS.Services.Mentor.Business/Implementations/MentorBusinessService.cs
Outdated
Show resolved
Hide resolved
Services/Mentor/OJS.Services.Mentor.Business/Implementations/MentorBusinessService.cs
Outdated
Show resolved
Hide resolved
Services/Mentor/OJS.Services.Mentor.Business/Implementations/MentorBusinessService.cs
Outdated
Show resolved
Hide resolved
Services/Mentor/OJS.Services.Mentor.Business/Implementations/MentorBusinessService.cs
Outdated
Show resolved
Hide resolved
Services/Mentor/OJS.Services.Mentor.Business/Implementations/MentorBusinessService.cs
Outdated
Show resolved
Hide resolved
Services/Mentor/OJS.Services.Mentor.Business/Implementations/MentorBusinessService.cs
Outdated
Show resolved
Hide resolved
Services/Mentor/OJS.Services.Mentor.Business/Implementations/MentorBusinessService.cs
Outdated
Show resolved
Hide resolved
| if (timeUntilReset.Seconds > 0) | ||
| { | ||
| timeComponents.Add($"{timeUntilReset.Seconds} second{(timeUntilReset.Seconds > 1 ? "s" : "")}"); | ||
| } |
There was a problem hiding this comment.
I think seconds is not needed. Is this for a live counter?
| { | ||
| if (rowData.Length > 0) | ||
| { | ||
| rowData.Append(" ⦚ "); |
There was a problem hiding this comment.
What is this symbol? Do we use it somewhere else? Maybe extract into a constant.
| } | ||
| } | ||
|
|
||
| return resultContent.ToString().Trim(); |
There was a problem hiding this comment.
Is there a way for this to return empty string? We should handle it by adding the problem and contest name and instruct the bot to look for it in it's own data.
…ion-service-with-chatgpt
Closes https://github.com/SoftUni-Internal/exam-systems-issues/issues/1609
Closes https://github.com/SoftUni-Internal/exam-systems-issues/issues/1605
Closes https://github.com/SoftUni-Internal/exam-systems-issues/issues/1610
Closes https://github.com/SoftUni-Internal/exam-systems-issues/issues/1608