Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename data_dir to data #7211

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ocraftyone
Copy link
Contributor

Description

Sets the default data_dir to just data

@SoftFever
Copy link
Owner

SoftFever commented Oct 25, 2024

Thanks @Ocraftyone

I understand where you come from.
I chose to use data_dir instead of just data to avoid potential naming conflicts.
While this is unlikely to be an issue for Windows, where we'll place the data folder alongside the executable file within the specific Orca Slicer directory, the situation differs for Mac, as it's a bundled.

So I think it's better to use a slightly longer name is a safe choice here

e.g.
Some folder:
- OrcaSlicer.app
- xxx.app
- xxx(folder)
- data_dir

@Ocraftyone
Copy link
Contributor Author

@SoftFever How about orca_data instead? That would alleviate the concern for conflict and I personally think it is a bit of a better naming choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants