Remove debug files and filter them in gitignore #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakpaul
added
the
pr: status wip
olivier-roussel
approved these changes
Jan 20, 2025
alxbilger
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
@olivier-goury @VannesteFelix Could you just explain a bit more what the purpose of the function createDebug is?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! DO NOT MERGE !!
We need to decide between this PR and PR #152
This removes debug files and filter them in gitignore, avoiding to commit them in the repo and in the meantime having them in packages.
We need to define weather we still want to have those debug files in the repo or not, if not this PR should be merged, if yes, the other one is needed to reduce size of packages.