Skip to content

Updated version #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

Updated version #72

merged 1 commit into from
Apr 8, 2025

Conversation

dacoburn
Copy link
Collaborator

@dacoburn dacoburn commented Apr 8, 2025

In some cases when outputting the SARIF format certain alert attributed might not exist leading to:

AttributeError: 'NoneType' object has no attribute 'get'

Root Cause

No checks to make sure the class attributes existed before calling for Alert

Fix

Added explicit checks to make sure they did exist. Probably want to move this to the class at some point

Public Changelog

  • Fixed version for ensuring that the alert attributes exist when outputting to SARIF to prevent the CLI from erroring out unexpectedly

@dacoburn dacoburn added the Product Changelog New features for the public changelog label Apr 8, 2025
@dacoburn dacoburn requested a review from a team as a code owner April 8, 2025 17:13
@dacoburn dacoburn requested review from jdalton and rchatrath7 and removed request for a team April 8, 2025 17:13
Copy link

github-actions bot commented Apr 8, 2025

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.0.41.dev1

Docker image: socketdev/cli:pr-72

@obarrera obarrera self-requested a review April 8, 2025 17:14
Copy link
Contributor

@obarrera obarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dacoburn dacoburn merged commit 7d58fe8 into main Apr 8, 2025
6 checks passed
@dacoburn dacoburn deleted the doug/fix-missing-props-attribute branch April 8, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product Changelog New features for the public changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants