Repository navigation
refactor: remove obsolete vendoring machinery and duplicate crate code - #1279
Merged
Mikola Lysenko (mikolalysenko) merged 5 commits intoOct 9, 2026
Merged
Conversation
Replace service-only result wrappers with Result, remove dead local-build parameters and impossible branches, and share ledger construction and vendoring fixtures. Preserve public entry-point signatures, refusal diagnostics, extraction checks, and independent test oracles.
Mikola Lysenko (mikolalysenko)
marked this pull request as ready for review
October 9, 2026 14:58
Tanmay Singla (Tanmay182003)
approved these changes
Oct 9, 2026
Mikola Lysenko (mikolalysenko)
removed this pull request from the merge queue due to a manual request
Oct 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 9, 2026
7 tasks done
Collaborator
Author
|
bugbot run Generated by Claude Code |
5 tasks done
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2b43a69. Configure here.
Collaborator
Author
|
Ready for review (burn-down agent).
Generated by Claude Code |
Mikola Lysenko (mikolalysenko)
enabled auto-merge
October 9, 2026 18:22
Mikola Lysenko (mikolalysenko)
removed this pull request from the merge queue due to a manual request
Oct 9, 2026
Resolve conflicts with #1026 (credential redaction) and #1283 (Bun restore user registry config): - vendor/{cargo,composer_lock,gem,golang,npm_common,npm_dir,pypi, service_fetch}.rs: keep this branch's Result-based service fast paths and route the vendor_prebuilt_downloaded advisory through main's single VerifiedArchive::downloaded_warning builder. - patch/redirect/upstream/bun_lockb.rs: keep by_uuid/refuse_all_in from upstream/mod.rs (where this branch moved them) and import main's BunConfigOrder from upstream/npm.rs. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Mikola Lysenko (mikolalysenko)
enabled auto-merge
October 9, 2026 22:06
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 9, 2026
Mikola Lysenko (mikolalysenko)
deleted the
refactor/crate-bloat-cleanup
branch
October 9, 2026 23:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendoring still carried local-build fallback machinery after acquisition became service-only, including impossible result branches and unused inputs threaded through multiple backends. The crates also repeated archive validation, restore helpers, ledger initializers, and test setup.
Remove 2,133 net Rust lines across 73 files (1,410 added / 3,543 deleted). Public entry-point signatures, ledger serialization, refusal diagnostics, and artifact integrity checks are preserved.
Result; remove unused local-build arguments, request fields, and impossible branches.Validation against current
main(a8e9397fe):cargo check --locked --workspace --all-targets --all-featurespassed.cargo clippy --locked --workspace --all-features -- -D warningspassed.git diff --checkpassed.CHANGELOG.mdis untouched.Note
Medium Risk
Vendoring no longer falls back to local builds when prebuilts are missing, which changes runtime behavior for
--vendor-source=autousers; hostedgetrelease narrowing moved earlier but should be equivalent.Overview
Large cleanup that makes vendoring acquisition service-only and deletes duplicated helpers across the Rust workspace (~2k net lines removed).
Vendoring backends (cargo, composer, gem, golang, npm dir/tarball, maven, nuget, etc.) no longer thread local-install / patch-apply fallbacks: custom
ServiceAttemptenums becomeResult,ServicePolicydropsautovsservicebranching, andVendorServiceConfig::service_enabled()only checks offline + API client. Staging paths likestage_patch_dirandmaterialise_patched_copyrequire a verified prebuilt artifact or refuse.Shared construction and restore plumbing:
VendorEntry::newreplaces hand-built ledger structs in production and tests; benchmark fixtures get onefixture()inmod.rs; upstream restore helpers (by_uuid,read_or_refuse,refuse_all_in) move toupstream/mod.rs; Ivy parsing reusesformats::xml::attr;cleanup_failed_stageis centralized invendor/common.CLI behavior tweaks:
getrunsfilter_to_installed_releasesonce for hosted and agent dry-run previews (removing the duplicate hosted block); vendor dispatch simplifies ecosystem/service checks and nuget/maven source passing. Minor ecosystem parsing/display simplifications and removal of unused Gradleremove_apply_line.Reviewed by Cursor Bugbot for commit 2b43a69. Configure here.
Generated by Claude Code