-
Notifications
You must be signed in to change notification settings - Fork 33
add --reach-lazy-mode. update coana to v138 #998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v1.x
Are you sure you want to change the base?
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment @cursor review or bugbot run to trigger another review on this PR
| reachDisableAnalytics: Boolean(reachDisableAnalytics), | ||
| reachEcosystems, | ||
| reachExcludePaths, | ||
| reachLazyMode: Boolean(reachLazyMode), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing reachLazyMode in reachability flags validation check
The isUsingAnyReachabilityFlags variable validates that users don't pass reachability flags without also passing --reach. However, the new reachLazyMode flag was not added to this check. Other similar boolean flags like reachDisableAnalysisSplitting, reachSkipCache, and reachUseOnlyPregeneratedSboms are included. Without this addition, users can pass --reach-lazy-mode without --reach and won't receive the expected validation error message telling them to add the --reach flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtorp This valid? I do remember the check being there but off the top of my head forget what it was for ☝️
--reach-lazy-modeflag. It's an experimental JS reachability feature that may improve performance for some users.Note
Introduces a hidden reachability option for performance experimentation.
--reach-lazy-modeflag to reachability flags and plumbs it throughcmd-scan-create,cmd-scan-reach, CI, and GitHub scan defaults; forwarded to Coana as--lazy-modeinperform-reachability-analysis@coana-tech/clito14.12.138; bumps package to1.1.51and updates CHANGELOG and lockfileWritten by Cursor Bugbot for commit 90f8a9e. Configure here.