change discoverGhsaIds to use coana cli command 'find-vulnerabilities' #958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bump coana version
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
mtorp
approved these changes
Dec 2, 2025
Contributor
Author
|
@cursor review |
Contributor
Author
|
@cursor review |
Contributor
jdalton
reviewed
Dec 2, 2025
| : []), | ||
| ...fixConfig.unknownFlags, | ||
| ], | ||
| ['find-vulnerabilities', cwd, '--manifests-tar-hash', tarHash], |
Contributor
There was a problem hiding this comment.
@jfblaa Love the new command!
['find-vulnerabilities', cwd, '--manifests-tar-hash', tarHash]
<-- if there was also a --json flag we could get the output as json to simplify parsing
Ideally the less we parse the more resilient it is to changes
jdalton
approved these changes
Dec 2, 2025
jdalton
deleted the
jfblaa/rea-317-use-coana-cmd-find-vulnerabilities-for-discovering-ghsaids
branch
jdalton
added a commit
that referenced
this pull request
Dec 9, 2025
Ported from v1.x commit cdd5971 (#958) - Replace compute-fixes-and-upgrade-purls discovery with simpler find-vulnerabilities command - Parse GHSA IDs from JSON output on stdout instead of temp file - Remove temp file creation/cleanup for discovery - Add error handling for JSON parsing - Simplify discovery logic with direct stdout parsing The find-vulnerabilities command is more efficient and cleaner than using compute-fixes-and-upgrade-purls with --output-file for discovery. Based on PR #958
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump coana version
Note
Use Coana
find-vulnerabilities(JSON output) forsocket fixGHSA discovery, update tests and PR flow accordingly, bump@coana-tech/clito 14.12.110, and release v1.1.40 with a bug fix.socket fixfind-vulnerabilitiesand parse JSON output for GHSA IDs.--manifests-tar-hashand piped stdio.src/commands/fix/handle-fix-limit.test.mtsto expectfind-vulnerabilitiesand JSON ID output; validate limit and PR-adjustment behavior.1.1.40and updateCHANGELOG.md(fix vulnerability discovery; note Coana CLI update).@coana-tech/clito14.12.110.Written by Cursor Bugbot for commit 7dcf13e. Configure here.