Skip to content

fix: --limit flag not working in local mode #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdalton merged 2 commits into from
Nov 20, 2025
Merged

fix: --limit flag not working in local mode #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ab8f2b
fix(fix): resolve --limit flag not working in local mode
jdalton Nov 20, 2025
0af9e17
refactor(fix): rename test files to match naming convention
jdalton Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 src/commands/fix/cmd-fix-e2e.test.mts → src/commands/fix/cmd-fix.e2e.test.mts
View file
Open in desktop
File renamed without changes.
286 changes: 286 additions & 0 deletions src/commands/fix/cmd-fix.test.mts → ...commands/fix/cmd-fix.integration.test.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,4 +925,290 @@ describe('socket fix', async () => {
},
)
})

describe('--limit flag behavior', () => {
cmdit(
[
'fix',
FLAG_DRY_RUN,
'--limit',
'0',
FLAG_CONFIG,
'{"apiToken":"fakeToken"}',
],
'should accept --limit with value 0',
async cmd => {
const { code, stdout } = await spawnSocketCli(binCliPath, cmd)
expect(stdout).toMatchInlineSnapshot(`"[DryRun]: Not saving"`)
expect(code, 'should exit with code 0').toBe(0)
},
)

cmdit(
[
'fix',
FLAG_DRY_RUN,
'--limit',
'1',
FLAG_CONFIG,
'{"apiToken":"fakeToken"}',
],
'should accept --limit with value 1',
async cmd => {
const { code, stdout } = await spawnSocketCli(binCliPath, cmd)
expect(stdout).toMatchInlineSnapshot(`"[DryRun]: Not saving"`)
expect(code, 'should exit with code 0').toBe(0)
},
)

cmdit(
[
'fix',
FLAG_DRY_RUN,
'--limit',
'100',
FLAG_CONFIG,
'{"apiToken":"fakeToken"}',
],
'should accept --limit with large value',
async cmd => {
const { code, stdout } = await spawnSocketCli(binCliPath, cmd)
expect(stdout).toMatchInlineSnapshot(`"[DryRun]: Not saving"`)
expect(code, 'should exit with code 0').toBe(0)
},
)

cmdit(
['fix', FLAG_DRY_RUN, FLAG_CONFIG, '{"apiToken":"fakeToken"}'],
'should use default limit of 10 when --limit is not specified',
async cmd => {
const { code, stdout } = await spawnSocketCli(binCliPath, cmd)
expect(stdout).toMatchInlineSnapshot(`"[DryRun]: Not saving"`)
expect(code, 'should exit with code 0').toBe(0)
},
)

cmdit(
['fix', '--limit', '0', FLAG_CONFIG, '{"apiToken":"fake-token"}'],
'should handle --limit 0 in non-dry-run mode',
async cmd => {
const { code, stderr, stdout } = await spawnSocketCli(binCliPath, cmd)
const output = stdout + stderr
expect(output).toContain(
'Unable to resolve a Socket account organization',
)
expect(code, 'should exit with non-zero code').not.toBe(0)
},
)
})

describe('--id flag behavior', () => {
cmdit(
[
'fix',
FLAG_DRY_RUN,
FLAG_ID,
'GHSA-1234-5678-9abc',
FLAG_CONFIG,
'{"apiToken":"fakeToken"}',
],
'should accept single GHSA ID with --id flag',
async cmd => {
const { code, stdout } = await spawnSocketCli(binCliPath, cmd)
expect(stdout).toMatchInlineSnapshot(`"[DryRun]: Not saving"`)
expect(code, 'should exit with code 0').toBe(0)
},
)

cmdit(
[
'fix',
FLAG_DRY_RUN,
FLAG_ID,
'CVE-2021-12345',
FLAG_CONFIG,
'{"apiToken":"fakeToken"}',
],
'should accept single CVE ID with --id flag',
async cmd => {
const { code, stdout } = await spawnSocketCli(binCliPath, cmd)
expect(stdout).toMatchInlineSnapshot(`"[DryRun]: Not saving"`)
expect(code, 'should exit with code 0').toBe(0)
},
)

cmdit(
[
'fix',
FLAG_DRY_RUN,
FLAG_ID,
'pkg:npm/[email protected]',
FLAG_CONFIG,
'{"apiToken":"fakeToken"}',
],
'should accept single PURL with --id flag',
async cmd => {
const { code, stdout } = await spawnSocketCli(binCliPath, cmd)
expect(stdout).toMatchInlineSnapshot(`"[DryRun]: Not saving"`)
expect(code, 'should exit with code 0').toBe(0)
},
)

cmdit(
[
'fix',
FLAG_DRY_RUN,
FLAG_ID,
'GHSA-1234-5678-9abc,GHSA-abcd-efgh-ijkl',
FLAG_CONFIG,
'{"apiToken":"fakeToken"}',
],
'should accept comma-separated GHSA IDs',
async cmd => {
const { code, stdout } = await spawnSocketCli(binCliPath, cmd)
expect(stdout).toMatchInlineSnapshot(`"[DryRun]: Not saving"`)
expect(code, 'should exit with code 0').toBe(0)
},
)

cmdit(
[
'fix',
FLAG_DRY_RUN,
FLAG_ID,
'GHSA-1234-5678-9abc',
FLAG_ID,
'CVE-2021-12345',
FLAG_CONFIG,
'{"apiToken":"fakeToken"}',
],
'should accept multiple --id flags with different ID types',
async cmd => {
const { code, stdout } = await spawnSocketCli(binCliPath, cmd)
expect(stdout).toMatchInlineSnapshot(`"[DryRun]: Not saving"`)
expect(code, 'should exit with code 0').toBe(0)
},
)
})

describe('--limit and --id combination', () => {
cmdit(
[
'fix',
FLAG_DRY_RUN,
'--limit',
'1',
FLAG_ID,
'GHSA-1234-5678-9abc',
FLAG_CONFIG,
'{"apiToken":"fakeToken"}',
],
'should accept both --limit and --id flags together',
async cmd => {
const { code, stdout } = await spawnSocketCli(binCliPath, cmd)
expect(stdout).toMatchInlineSnapshot(`"[DryRun]: Not saving"`)
expect(code, 'should exit with code 0').toBe(0)
},
)

cmdit(
[
'fix',
FLAG_DRY_RUN,
'--limit',
'5',
FLAG_ID,
'GHSA-1234-5678-9abc,CVE-2021-12345,pkg:npm/[email protected]',
FLAG_CONFIG,
'{"apiToken":"fakeToken"}',
],
'should accept --limit with multiple vulnerability IDs',
async cmd => {
const { code, stdout } = await spawnSocketCli(binCliPath, cmd)
expect(stdout).toMatchInlineSnapshot(`"[DryRun]: Not saving"`)
expect(code, 'should exit with code 0').toBe(0)
},
)

cmdit(
[
'fix',
FLAG_DRY_RUN,
'--limit',
'1',
FLAG_ID,
'GHSA-1234-5678-9abc',
'--autopilot',
FLAG_CONFIG,
'{"apiToken":"fakeToken"}',
],
'should accept --limit, --id, and --autopilot together',
async cmd => {
const { code, stdout } = await spawnSocketCli(binCliPath, cmd)
expect(stdout).toMatchInlineSnapshot(`"[DryRun]: Not saving"`)
expect(code, 'should exit with code 0').toBe(0)
},
)

cmdit(
[
'fix',
'--limit',
'2',
FLAG_ID,
'GHSA-1234-5678-9abc,GHSA-abcd-efgh-ijkl',
FLAG_CONFIG,
'{"apiToken":"fake-token"}',
],
'should handle --limit and --id in non-dry-run mode',
async cmd => {
const { code, stderr, stdout } = await spawnSocketCli(binCliPath, cmd)
const output = stdout + stderr
expect(output).toContain(
'Unable to resolve a Socket account organization',
)
expect(code, 'should exit with non-zero code').not.toBe(0)
},
)

cmdit(
[
'fix',
FLAG_DRY_RUN,
'--limit',
'3',
FLAG_ID,
'GHSA-1234-5678-9abc',
FLAG_JSON,
FLAG_CONFIG,
'{"apiToken":"fakeToken"}',
],
'should accept --limit, --id, and --json output format together',
async cmd => {
const { code, stdout } = await spawnSocketCli(binCliPath, cmd)
expect(stdout).toMatchInlineSnapshot(`"[DryRun]: Not saving"`)
expect(code, 'should exit with code 0').toBe(0)
},
)

cmdit(
[
'fix',
FLAG_DRY_RUN,
'--limit',
'10',
FLAG_ID,
'CVE-2021-12345',
FLAG_MARKDOWN,
FLAG_CONFIG,
'{"apiToken":"fakeToken"}',
],
'should accept --limit, --id, and --markdown output format together',
async cmd => {
const { code, stdout } = await spawnSocketCli(binCliPath, cmd)
expect(stdout).toMatchInlineSnapshot(`"[DryRun]: Not saving"`)
expect(code, 'should exit with code 0').toBe(0)
},
)
})
})
Loading