fix(smol): update inspector protocol Windows patch #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdalton
force-pushed
the
fix/inspector-protocol-windows-patch
branch
from
92d0436 to
d54b395
Compare
Add patch 012 to fix Windows build failure in inspector_protocol code_generator.py. On Windows, the gyp-win-tool action wrapper fails to pass --config_value protocol.path=... through ninja response files, causing AttributeError in two locations (lines 365 and 635). Solution: Check for missing config.protocol.path in main() before creating Protocol object, compute the path from config_file location, and update the config namedtuple using _replace(). Also hoist logger to module scope in socket package build script.
jdalton
force-pushed
the
fix/inspector-protocol-windows-patch
branch
from
bedede6 to
0133242
Compare
Matrix context variables are not parsed in job-level name fields.
Changed from dynamic '⚡ Smol - ${{ matrix.platform }}-${{ matrix.arch }}'
to static '⚡ Smol Binaries'.
- Remove git-style diff headers (diff --git, index) - Use simple unified diff format (--- and +++) - Match format of other patches in the directory Fixes patch validation failure in build-smol workflow.
Restore original git-diff formatted patch that was working. The previous attempt to convert to unified diff format failed validation.
- Create patch from actual Node.js source using diff -u - Properly formats all added lines with + prefix - Tested with patch -p1 --dry-run, applies cleanly - Fixes AttributeError: 'X' object has no attribute 'path' - Adds fallback to compute protocol path from config file location Refs: #876
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Windows-specific inspector protocol patch for Node.js v24.10.0 to fix namedtuple ValueError issues in the Python build script.
Problem
The previous patch attempted to modify a namedtuple after creation, which caused an AttributeError in Python 3.11+:
This occurred because namedtuples are immutable and cannot have attributes assigned after creation.
Solution
Simplified the patch to compute the protocol path from the config file location and use it directly, without attempting to modify the namedtuple. The fix:
config_fileparameter inProtocol.__init__()config.protocol.pathis missingChanges
Test plan
pnpm --filter @socketbin/node-smol-builder run buildRelated
This patch ensures proper handling of Windows paths in the inspector protocol build process for the Socket smol Node.js binary.