feat(manifest): mark build modules as firstParty in facts components - #1569
Merged
Jeppe Fredsgaard Blaabjerg (jfblaa) merged 3 commits intoSep 29, 2026
Merged
Conversation
Components whose exact GAV is a module of the scanned build now carry `firstParty: true` in .socket.facts.json, for maven, gradle and sbt. This lets dependency resolution stop treating the build's own modules as published packages that block upgrades. The match reuses the same GAV lookup that attaches project sources/targets. Published releases of a sibling module stay unmarked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Jeppe Fredsgaard Blaabjerg (jfblaa)
marked this pull request as draft
September 29, 2026 08:21
Jeppe Fredsgaard Blaabjerg (jfblaa)
marked this pull request as ready for review
September 29, 2026 08:51
Oskar Haarklou Veileborg (BarrensZeppelin)
approved these changes
Sep 29, 2026
Oskar Haarklou Veileborg (BarrensZeppelin)
left a comment
Oskar Haarklou Veileborg (BarrensZeppelin)
left a comment
Member
There was a problem hiding this comment.
LGTM
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Jeppe Fredsgaard Blaabjerg (jfblaa)
deleted the
jfblaa/facts-first-party
branch
September 29, 2026 11:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Description written by Claude Code:claude-opus-5-5
Important
Release gate: do not merge until this branch also bumps the bundled
@coana-tech/clito a version whose--compute-artifacts-sidecarschema acceptscomponents[].firstParty. Released coana versions parse the sidecar strictly and reject the key ("Invalid --compute-artifacts-sidecar"), which breakssocket scan --reachandsocket fix --dynamic-sbom-inference.Components in
.socket.facts.jsonwhose exact GAV is a module of the scanned build now carryfirstParty: true(maven, gradle, sbt). The field is omitted otherwise, neverfalse.Why: on multi-module builds,
socket fixtreated a sibling module that pins a vulnerable dependency as a published package blocking the upgrade ("no version of org.example:A is compatible"). With the build's own modules marked, depscan proposes the direct upgrade instead.sources/targets; qualifiers are not compared.internalis unchanged.components[]carry the field as plain copies of the facts components; sidecarprojects[]never do (tested).🤖 Generated with Claude Code