feat(interceptors): add UnauthorizedInterceptor to handle 401 errors #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mzem
reviewed
Jan 20, 2025
Mzem
reviewed
Jan 27, 2025
| import 'package:pass_emploi_app/repositories/remote_config_repository.dart'; | ||
| import 'package:redux/redux.dart'; | ||
|
|
||
| class UnauthorizedInterceptor extends PassEmploiBaseInterceptor { |
There was a problem hiding this comment.
Peut etre nommer l'interceptor en LogoutAfterTooMany401Interceptor ?
Mzem
reviewed
Jan 27, 2025
|
|
||
| @override | ||
| void onPassEmploiError(DioException err, ErrorInterceptorHandler handler) { | ||
| final maxUnauthorizedErrorsBeforeLogout = _remoteConfigRepository.maxUnauthorizedErrorsBeforeLogout(); |
There was a problem hiding this comment.
en termes de perf ça bouffe quoi d'avoir ce genre d'interceptor qui écoute en permanence les status code d'appel d'api ?
There was a problem hiding this comment.
C'est pas grand chose. C'est un appel de fonction en plus avec un if. Il n'y a pas de grosse logique donc même avec un iphone 4s pas de soucis
Mzem
reviewed
Jan 27, 2025
| } | ||
|
|
||
| void _onUnauthorizedErrorCountExceeded() { | ||
| _store.dispatch(RequestLogoutAction(LogoutReason.tooMany401)); |
There was a problem hiding this comment.
et cette fonction elle force le logout aussi ?
There was a problem hiding this comment.
Oui le logout est piloté dans Redux
…any401Interceptor and update references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.