Open
Conversation
whether WSPeer inherits from Peer as well as RTCPeer?
Contributor
|
What additional value does this PR bring? It seems the inheritance is not necessary as it works without it as well... |
Author
I think this is a very hidden problem when fallback to websocket send msg and it can be reproduced Steps to reproduce
This error means WSPeer not properly initialized. Its really only have _send method!! |
Contributor
|
Ah, ok. Thanks for clarification and for helping to improve Snapdrop! |
yjmp14
added a commit
to yjmp14/wulingate
that referenced
this pull request
Nov 17, 2022
fix WSPeer SnapDrop#458 fix this._isCaller variable typo SnapDrop#531
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whether WSPeer inherits from Peer as well as RTCPeer?