Add dashboard thumbnails #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/snakeroom/snakeroom/3wGn25Hf7oUFxZJgN2pEWQzZGqXj |
haykam821
reviewed
Apr 2, 2022
Comment on lines
+34
to
+38
| static Joining = new MembershipStatus("Joining...", "🔃"); | ||
| static Joined = new MembershipStatus("Joined", "✅"); | ||
| static Leaving = new MembershipStatus("Leaving...", "🔃"); | ||
| static NotJoined = new MembershipStatus("Not Joined", "❌"); | ||
| static Unknown = new MembershipStatus("Unknown", "❔"); |
Member
There was a problem hiding this comment.
Could Font Awesome icons be used instead of emojis here?
Comment on lines
+120
to
+124
| membershipStatus === MembershipStatus.Joined ? "➖ Leave" : | ||
| membershipStatus === MembershipStatus.Joining ? "➕ Joining..." : | ||
| membershipStatus === MembershipStatus.NotJoined ? "➕ Join" : | ||
| membershipStatus === MembershipStatus.Leaving ? "➖ Leaving..." : | ||
| "Error" |
Member
There was a problem hiding this comment.
These values could be stored in the MembershipStatus instances.
Contributor
|
This pull request is for an event that has ended and therefore I will close it. Should it become relevant again, it should be reopened. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dashboard thumbnails using the /y22/projects/:uuid/bitmap endpoint.
Make the /projects page much more responsive