Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: random integer iterators and streams #84

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

studiosi
Copy link

No description provided.

@studiosi studiosi changed the title feat: random integers wip: random integers Mar 11, 2025
@studiosi studiosi marked this pull request as draft March 11, 2025 12:55
@studiosi studiosi marked this pull request as ready for review March 11, 2025 14:34
@studiosi studiosi changed the title wip: random integers feat: random integer iterators and streams Mar 11, 2025
@coveralls
Copy link

coveralls commented Mar 12, 2025

Pull Request Test Coverage Report for Build 13788547605

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 24 of 24 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 13062161073: 0.0%
Covered Lines: 1482
Relevant Lines: 1482

💛 - Coveralls

@Smoren
Copy link
Owner

Smoren commented Mar 23, 2025

Hi @studiosi! Thank you for PR!
I see that you used a third-party library to implement new functionality. The thing is, I would like itertools to remain a dependency-free library, so I would like to ask you to rework this PR so that new features do not use a third-party library.

I would also like to ask you to implement tests using data providers, similar to the tests written earlier.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants