Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update downcast-rs to 2.0 #777

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update downcast-rs to 2.0 #777

wants to merge 1 commit into from

Conversation

torokati44
Copy link
Contributor

Simple housekeeping, no other particular reason.

This would deduplicate in the future what https://github.com/ruffle-rs/ruffle/pull/19205/files duplicates for us.

@torokati44
Copy link
Contributor Author

See the changelog: https://github.com/marcianx/downcast-rs/blob/master/CHANGELOG.md#200---2025-01-06

@torokati44 torokati44 mentioned this pull request Jan 13, 2025
Merged
@ids1024
Copy link
Member

ids1024 commented Jan 16, 2025

https://docs.rs/wayland-backend/0.3.7/wayland_backend/sys/client/struct.Backend.html#impl-Downcast-for-T

It seems the public API of wayland-backend does export types implementing traits from downcast-rs, so this is (at least) technically a breaking API change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torokati44 @ids1024