WIP Enable clippy::same_name_method lint

src/backend/renderer/gles/mod.rs

@@ -2459,7 +2459,7 @@ impl GlesFrame<'_> {
     /// Optionally allows a custom texture program and matching additional uniforms to be passed in.
     #[instrument(level = "trace", skip(self), parent = &self.span)]
     #[profiling::function]
-    #[allow(clippy::too_many_arguments)]
+    #[allow(clippy::same_name_method, clippy::too_many_arguments)]
     pub fn render_texture_from_to(
         &mut self,
         texture: &GlesTexture,

src/desktop/space/wayland/x11.rs

@@ -21,7 +21,7 @@ use super::{output_update, WindowOutputUserData};
 impl WaylandFocus for X11Surface {
     #[inline]
     fn wl_surface(&self) -> Option<Cow<'_, WlSurface>> {
-        self.state.lock().unwrap().wl_surface.clone().map(Cow::Owned)
+        self.wl_surface().map(Cow::Owned)
     }
 }
 

src/desktop/wayland/layer.rs

@@ -530,6 +530,7 @@ impl LayerSurface {
 
     /// Returns the underlying [`WlSurface`]
     #[inline]
+    #[allow(clippy::same_name_method)]
     pub fn wl_surface(&self) -> &WlSurface {
         self.0.surface.wl_surface()
     }
@@ -721,6 +722,6 @@ impl LayerSurface {
 impl WaylandFocus for LayerSurface {
     #[inline]
     fn wl_surface(&self) -> Option<Cow<'_, wl_surface::WlSurface>> {
-        Some(Cow::Borrowed(self.0.surface.wl_surface()))
+        Some(Cow::Borrowed(self.wl_surface()))
     }
 }

src/lib.rs

@@ -1,5 +1,10 @@
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
-#![warn(missing_docs, missing_debug_implementations, rust_2018_idioms)]
+#![warn(
+    missing_docs,
+    missing_debug_implementations,
+    rust_2018_idioms,
+    clippy::same_name_method
+)]
 // Allow acronyms like EGL
 #![allow(clippy::upper_case_acronyms)]
 

src/wayland/drm_syncobj/sync_point.rs

@@ -79,6 +79,7 @@ impl DrmSyncPoint {
     }
 
     /// Wait for sync point.
+    #[allow(clippy::same_name_method)]
     pub fn wait(&self, timeout_nsec: i64) -> io::Result<()> {
         self.timeline.0.device.syncobj_timeline_wait(
             &[self.timeline.0.syncobj],

src/xwayland/xwm/surface.rs

@@ -317,6 +317,7 @@ impl X11Surface {
     ///     shell](crate::wayland::xwayland_shell) protocol on the wayland side,
     ///     and then committed.
     #[inline]
+    #[allow(clippy::same_name_method)]
     pub fn wl_surface(&self) -> Option<WlSurface> {
         self.state.lock().unwrap().wl_surface.clone()
     }