Skip to content

Conversation

@az-smartling
Copy link
Contributor

Return information about job

@gemini-code-assist
Copy link

Summary of Changes

Hello @az-smartling, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the user feedback provided after a file push operation by displaying comprehensive information about the associated Smartling job. It ensures that users can quickly access the job's unique identifier, its human-readable name, and a direct link to its page within the Smartling dashboard, streamlining the workflow for tracking translation jobs. This enhancement is supported by an update to the Smartling API SDK and new logic for retrieving and presenting job details.

Highlights

  • Enhanced Job Information Output: The runPush function now prints the Smartling Job UID, Job Name, and a direct URL to the job in the Smartling dashboard after a file push operation.
  • Dynamic Job Name Retrieval: Logic has been added to explicitly retrieve the job name using s.BatchApi.GetJob if an existing job is being used and its name is not immediately available.
  • Smartling API SDK Update: The github.com/Smartling/api-sdk-go dependency has been updated to a newer version, likely providing the necessary API capabilities for the enhanced job information.
  • New Utility Function: A getJobURL helper function was introduced to construct the correct Smartling dashboard URL for a given project and job UID.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the push command by displaying the Smartling job's UID, name, and URL after execution. This is a helpful addition for users. The implementation correctly handles cases for both creating a new job and using an existing one. My review includes a suggestion to improve the maintainability and readability of the new getJobURL function by using string formatting, which is more idiomatic in Go.

}

func getJobURL(projectUID, jobUID string) string {
return "https://dashboard.smartling.com/app/projects/" + projectUID + "/account-jobs/" + projectUID + ":" + jobUID

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and maintainability, it's idiomatic in Go to use fmt.Sprintf for string formatting instead of concatenation, especially when constructing complex strings like URLs. This makes the intended structure of the URL clearer at a glance. For further improvement, consider defining the URL format string as a package-level constant.

Suggested change
return "https://dashboard.smartling.com/app/projects/" + projectUID + "/account-jobs/" + projectUID + ":" + jobUID
return fmt.Sprintf("https://dashboard.smartling.com/app/projects/%s/account-jobs/%s:%s", projectUID, projectUID, jobUID)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants