Nsng 593 gtm #22
Nsng 593 gtm #22
Conversation
nuxt.config.ts
Outdated
| @@ -29,11 +28,22 @@ export default defineNuxtConfig({ | |||
| apiUrl: process.env.NUXT_API_URL, | |||
| }, | |||
| }, | |||
| gtm: { | |||
| id: process.env.NUXT_APP_GTM_ID || '', | |||
| enabled: true, // Enable GTM tracking | |||
There was a problem hiding this comment.
disable on develop? or settrue only if ess.env.NUXT_APP_GTM_ID is not empty? (just an idea)
| @@ -29,11 +28,22 @@ export default defineNuxtConfig({ | |||
| apiUrl: process.env.NUXT_API_URL, | |||
| }, | |||
| }, | |||
| gtm: { | |||
| id: process.env.NUXT_APP_GTM_ID || '', | |||
| enabled: process.env.NUXT_APP_GTM_ID === 'true' ? true : false, // Enable GTM tracking | |||
There was a problem hiding this comment.
@igor-kamil could not come up with anything better
There was a problem hiding this comment.
| enabled: process.env.NUXT_APP_GTM_ID === 'true' ? true : false, // Enable GTM tracking | |
| enabled: process.env.NUXT_APP_GTM_ENABLED === 'true' ? true : false, // Enable GTM tracking |
would be better 😂
however enabled doesn't seems to really work anyway. I've found this workaround
There was a problem hiding this comment.
TBH, I am not sure, whether @zadigetvoltaire/nuxt-gtm is a good choice.
apparently not maintained anymore. Also it breaks the app (=returns 500) until you define the GTM ID (what will make it impossible even to run tests).
Also it seems to be not such a big deal to implement it without any package -> https://scripts.nuxt.com/scripts/tracking/google-tag-manager
But to sum it up - I consider it as your project and as an owner you can still merge this (please just accept the suggestion - right now you don't use NUXT_APP_GTM_ENABLED in the code at all).
Otherwise I suggest to implement it without requiring to set GTM_ID
| @@ -29,11 +28,22 @@ export default defineNuxtConfig({ | |||
| apiUrl: process.env.NUXT_API_URL, | |||
| }, | |||
| }, | |||
| gtm: { | |||
| id: process.env.NUXT_APP_GTM_ID || '', | |||
| enabled: process.env.NUXT_APP_GTM_ID === 'true' ? true : false, // Enable GTM tracking | |||
There was a problem hiding this comment.
| enabled: process.env.NUXT_APP_GTM_ID === 'true' ? true : false, // Enable GTM tracking | |
| enabled: process.env.NUXT_APP_GTM_ENABLED === 'true' ? true : false, // Enable GTM tracking |
would be better 😂
however enabled doesn't seems to really work anyway. I've found this workaround
Needs to be tested and consulted