Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Remove spare f in an f-string #225

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

jennydaman
Copy link
Contributor

@jennydaman jennydaman commented Dec 26, 2023

Remove a spare f when redirecting the output of a 3D Slicer command
call using an f-string in the transform hardening script.

Inadvertently introduced in commit ac6040f.

@jhlegarreta
Copy link
Contributor

jhlegarreta commented Jan 1, 2024

@jennydaman Thanks for the patch set !

Can you please amend your commit and push force with the following changes?

  • Add the BUG: commit prefix to the commit subject line.
  • Add a commit message body with a more elaborate message, e.g. explaining the failure this patch set fixes.

You can find some examples of accurate messages in the commit history. This blog post is very enlightening: https://cbea.ms/git-commit/amp/

@jennydaman
Copy link
Contributor Author

@jhlegarreta I force-pushed a better commit message.

@jhlegarreta
Copy link
Contributor

@jhlegarreta I force-pushed a better commit message.

@jennydaman Only the commit message body was changed; there is no commit message body. I will amend and push force.

Remove a spare `f` when redirecting the output of a 3D Slicer command
call using an f-string in the transform hardening script.

Inadvertently introduced in commit ac6040f.
@jhlegarreta jhlegarreta changed the title Fix typo in wm_harden_transform.py BUG: Remove spare f in an f-string Jan 4, 2024
@jhlegarreta
Copy link
Contributor

CI build failures are unrelated (cross-referencing #226 (comment)).

Thanks for having detected and fixed this @jennydaman.

Merging.

@jhlegarreta jhlegarreta merged commit b73d073 into SlicerDMRI:master Jan 4, 2024
11 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants