Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Relax the Python package version requirements #157

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

jhlegarreta
Copy link
Contributor

@jhlegarreta jhlegarreta commented Sep 27, 2023

Relax the Python package version requirements: constrain versions within
a range, and test the min and max versions so that there is some more
flexibility when using different package versions.

@jhlegarreta
Copy link
Contributor Author

Should help the builds in PR #153 to pass.

@jhlegarreta jhlegarreta force-pushed the RelaxRequiredPackageVersions branch 5 times, most recently from 7579594 to 70e1722 Compare September 27, 2023 18:29
@jhlegarreta jhlegarreta force-pushed the RelaxRequiredPackageVersions branch 4 times, most recently from 1b9db12 to 16e95aa Compare October 4, 2023 19:03
@jhlegarreta jhlegarreta force-pushed the RelaxRequiredPackageVersions branch 2 times, most recently from 16e95aa to 5993820 Compare October 5, 2023 14:48
@jhlegarreta jhlegarreta force-pushed the RelaxRequiredPackageVersions branch 5 times, most recently from 4362288 to f960f18 Compare October 12, 2023 18:46
@jhlegarreta
Copy link
Contributor Author

jhlegarreta commented Oct 12, 2023

Packages are being installed correctly for all versions, e.g.
https://github.com/SlicerDMRI/whitematteranalysis/actions/runs/6500137270/job/17654901677?pr=157#step:6:608

Tests should pass after PR #176 gets merged and this PR rebased on master.

Relax the Python package version requirements: constrain versions within
a range, and test the min and max versions so that there is some more
flexibility when using different package versions.
@ljod ljod merged commit b4a25ff into SlicerDMRI:master Oct 19, 2023
0 of 9 checks passed
@jhlegarreta jhlegarreta deleted the RelaxRequiredPackageVersions branch October 19, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants