Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Make tractogram downsampling results reproducible by default #147

Merged
merged 2 commits into from
Sep 21, 2023
Merged

ENH: Make tractogram downsampling results reproducible by default #147

merged 2 commits into from
Sep 21, 2023

Conversation

jhlegarreta
Copy link
Contributor

@jhlegarreta jhlegarreta commented Sep 9, 2023 •
edited
Loading

  • ENH: Make tractogram downsampling results reproducible by default
  • ENH: Allow non-identical results in tractogram downsampling

@jhlegarreta
ENH: Make tractogram downsampling results reproducible by default
fea55a3 
Make tractogram downsampling results reproducible by default: set a
default value to the random seed.
@jhlegarreta
ENH: Allow non-identical results in tractogram downsampling
96f6719 
Allow non-identical results in tractogram downsampling: add a flag so
that the random seed value is set to `None` when it is used, and thus,
allow for non-identical results when randomly drawing a subset of
streamlines.

The default behavior is to obtain reproducible (identical) results
across runs after the change introduced in commit fea55a3.
@jhlegarreta jhlegarreta force-pushed the AllowTractogramDownsamplingReproducibility branch from 574a0b1 to 96f6719 Compare September 10, 2023 20:27
@jhlegarreta jhlegarreta changed the title ENH: Allow reproducible results in tractogram downsampling ENH: Make tractogram downsampling results reproducible by default Sep 10, 2023
@jhlegarreta
Copy link
Contributor Author

Checked locally that his makes the downsampling results reproducible, and that using the --nonidentical flag keeps the previous behavior (downsampled tractograms contain different data). Ideally testing should be added (applies also to the whole toolset); but that is left for a separate piece of work.

@jhlegarreta jhlegarreta marked this pull request as ready for review September 12, 2023 21:33
ljod
ljod approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@ljod ljod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@ljod ljod merged commit 3f74faf into SlicerDMRI:master Sep 21, 2023
1 check passed
@jhlegarreta jhlegarreta deleted the AllowTractogramDownsamplingReproducibility branch September 21, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljod ljod ljod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhlegarreta @ljod