WIP - Add compatibility with SAM models #118
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoucheiron
reviewed
Nov 27, 2023
| AWSTemplateFormatVersion: Optional[date] | ||
| Conditions: Optional[Dict] = {} | ||
| Description: Optional[str] = None | ||
| Globals: Optional[Dict] = {} |
There was a problem hiding this comment.
I'd create a subclass for SAM. Normal CF does not support Globals
There was a problem hiding this comment.
It was one of the ideas I had in mind. I'd try to give this PR some development time this week and do a subclass instead for SAM 👍
|
Should we close this one? |
We don't have to. It's just an unplanned feature since:
Happy to receive contributions on it. Ultimately closes an issue in CFRipper and has broader compatibility with other CloudFormation models. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Solving issue for SAM templates found in: Skyscanner/cfripper#259