Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to override server provider default DNS nameservers #310

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

firyx
Copy link
Collaborator

@firyx firyx commented May 16, 2022

PULL REQUEST

Overview

Novogara server provider is using local DNS caching resolver unbound. It seems it is not configured correctly and doesn't resolve some domains, e.g. sia-storage.net.

This PR removes usage of unbound and uses custom defined nameservers set via ansible-private variable.

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the PR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Verify if any changes impact the WebPortal Health Checks
  • Approriate documentation updated
  • Changelog file created

Issues Closed

@firyx firyx requested a review from MSevey as a code owner May 16, 2022 09:05
@linear
Copy link

linear bot commented May 16, 2022

@firyx firyx self-assigned this May 16, 2022
@firyx firyx requested a review from kwypchlo May 16, 2022 09:05
Copy link
Contributor

@kwypchlo kwypchlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes usage of unbound and uses custom defined nameservers set via ansible-private variable.

I don't think I like this solution, using unbound has its merits and we're removing it even if it's the default that came with debian distro. We should figure out what was wrong and fix that instead of dropping the cache layer completely and adding complexity for portal operators - how would a portal operator even decide which server he needs to overwrite the nameservers on, there's not immediate error or anything happening, the only way we figured out that the dns was not resolving was a user reporting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants