Include JSQMessagesViewController in public headers #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a partial fix for the problem you are having @tensiuyan |
|
checkout this branch to evaluate this pull request using the demo project https://github.com/cheungpat/SkygearChat-iOS-Demo/tree/fix-for-1.2.0 |
I've just tested with the demo, and it failed to build because the chat sdk in pod cannot find the jsq classes. I find the source code of jsq classes are not found in the pods folder. |
|
The demo is working after adding a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows projects using SKYKitChat to use JSQ classes,
which is now embedded in the SKYKitChat.
refs #136