Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with using JSQMessagesViewController classes embedded in SKYKitChat #136

Open
cheungpat opened this issue Nov 30, 2017 · 0 comments

Comments

@cheungpat
Copy link
Contributor

@tensiuyan discovered that the SkygearChat-iOS-Demo is unable to compile with 1.2.0-alpha.1 of SKYKitChat/UI. Compilation problems are related to the use of JSQ classes in the demo project.

It appears that the JSQMessagesViewController library is embedded into SKYKitChat, and so from the Cocoapods point of view, there is no longer a framework with the name JSQMessagesViewController, and import JSQMessagesViewController in swift demo project no longer works.

The podspec doesn’t specify the header files in JSQMessagesViewController, so swift demo project cannot use the JSQ classes either. (I am going to send a pull request for this.)

If accepting the pull request, the swift demo has to make the following changes in order to use SKYKitChat:

  • Remove JSQMessagesViewController from Podfile because the classes are already embedded in SKYKitChat
  • Replace all instances of import JSQMessagesViewController with import SKYKitChat (if the latter one is not already imported)

In other words, people who need to use JSQ classes must not include JSQMessagesViewController as a dependency in their Podfile and should import SKYKitChat in swift code.

This issue serves to discuss the recommended way for developer who need to use JSQ classes in their chat app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant