-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: simplify e2e test script #133
Conversation
Signed-off-by: WangBaiping <[email protected]>
Signed-off-by: WangBaiping <[email protected]>
This should also fixed CI problem in the #132 |
The coverage report was broken and we may need to remove it because the codecov only provide limited support to the free users. |
friendly ping @wu-sheng |
I can see you changed the CI names. Is that expected? And, there is one CI process fails. |
I could change the required CIs, if those new names are expected. |
yeah, the new names are expected. |
New UT fail should be fixed? |
The coverage reporting is broken because the it's rate limited. /sad |
How about we remove that to keep CI green? |
I am inclined to remove the coverage reporting from the CI and add a simple coverage ratio checking in our CI directly with a new PR. |
Please go ahead. Personally, I am not a fun about coverage rate. |
Should I merge first or wait foe your update? |
If you don't care it's coverage ratio, then I can remove the failed coverage reporting directly in this PR. :) |
I will push the new commit tonight |
Signed-off-by: WangBaiping <[email protected]>
provider.cc
actually is consumer and theconsumer.cc
actually is provider.