Improve return types for ExprExpression and ExprChangeValue #157
+59
−279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to improve the return types for
ExprExpressionandExprChangeValue. On Skript 2.14, they do not work well with property syntax. They use the outdated (and potentially dangerous) approach of typing themselves. This causes unexpected behavior, such as property syntaxes not working with expressions that should be supported.To resolve this, I have rewritten both of the expressions. For now, only use as Object return type as the current setup prevents determining this information without more significant changes (and it won't really have a big impact)