Changeable Conditions#8707
Open
APickledWalrus wants to merge 6 commits into
Open
Conversation
APickledWalrus
requested review from
UnderscoreTud and
erenkarakal
and removed request for
a team
skriptlang-automation
Bot
added
needs reviews
This comment has been minimized.
This comment has been minimized.
skriptlang-automation
Bot
added
feature
Contributor
|
So just to verify... Feels messy. Feels redundant. With all due respect, I think you guys need to have a team meeting, chill, step back... and starting thinking more about your users and less about yourselves. |
sovdeeth
requested changes
Jun 22, 2026
Comment on lines
+194
to
+195
| * @param value The new value. | ||
| * This is always false for {@link ChangeMode#DELETE} and {@link ChangeMode#RESET}. |
Member
There was a problem hiding this comment.
maybe call newValue or deltaValue
| * @param what The property holder. | ||
| * @param value The new value. | ||
| * This is always false for {@link ChangeMode#DELETE} and {@link ChangeMode#RESET}. | ||
| * @param mode The type of change to perform. |
Member
There was a problem hiding this comment.
probably contract that add/remove/removall shouldn't be used
| @Since("2.11") | ||
| public class CondIsEating extends PropertyCondition<LivingEntity> { | ||
|
|
||
| private static final boolean SUPPORTS_HORSES = Skript.methodExists(AbstractHorse.class, "isEating"); |
Member
There was a problem hiding this comment.
I think this is in 1.21.4 so can be removed
| @Since("2.5, 2.10 (gamemode)") | ||
| public class CondIsInvulnerable extends PropertyCondition<Object> { | ||
|
|
||
| private static final boolean SUPPORTS_GAMEMODE = Skript.methodExists(GameMode.class, "isInvulnerable"); |
Comment on lines
30
to
31
| // TODO - remove this when Spigot support is dropped | ||
| private static final boolean CAN_USE_ENTITIES = Skript.methodExists(Mob.class, "isLeftHanded"); |
| @Since("2.11") | ||
| public class CondIsScreaming extends PropertyCondition<LivingEntity> { | ||
|
|
||
| private static final boolean SUPPORTS_ENDERMAN = Skript.methodExists(Enderman.class, "isScreaming"); |
| @Since("1.3.4") | ||
| public class CondPvP extends Condition { | ||
|
|
||
| private static final boolean PVP_GAME_RULE_EXISTS = Skript.fieldExists(GameRule.class, "PVP"); |
Comment on lines
+19
to
+24
| @Description(""" | ||
| A shorthand for returning the result of a condition (true or false). | ||
| This is functionally identical to using 'true if <condition> else false'. | ||
| """) | ||
| @Example("set {fly} to whether player can fly") | ||
| @Example("broadcast \"Flying: %whether player is flying%\"") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For some time, we have been recommending a combination of Condition+Effect in favor of a boolean Expression. However, there is some loss of ease of use:
toggle the player's gliding stateset the player's gliding state to {_boolean}If Conditions were to support changing, these features could be restored in some manner, preserving the ease of use options provided by boolean Expressions.
Solution
This PR proposes a simple API for changing the values represented by conditions. This API is further extended by PropertyCondition to make implementing even easier.
I decided to allow any changer to be used, though some modes are likely pointless. We could instead have specific methods for whether
SETorRESETare allowed (as an example as those are probably the only realistic modes to support). I'd like opinions to tweak this.This API is then used by ExprWhether to allow changing conditions:
toggle whether player is glidingset whether the player is gliding to {_boolean}There is a large number of files changed as I implemented this for most conditions where it made sense.
Testing Completed
Some in-game testing. I added at least 40 new tests covering many of the updated conditions.
Supporting Information
n/a
Completes: none
Related: none
AI assistance: none